Wireshark-commits: [Wireshark-commits] master d9da77a: Have various ATM dissectors use the data arg
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 14 Jan 2016 00:04:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d9da77afe85ce91086be80df8802c565c8f9d84d
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d9da77a by Guy Harris (guy@xxxxxxxxxxxx):

    Have various ATM dissectors use the data arguments for pseudo-headers.
    
    Don't use the pseudo-header pointed to by pinfo->pseudo_header; have the
    argument either point to a struct atm_phdr or to a pwatm_private_data_t.
    
    Don't *overwrite* the pseudo-header pointed to by pinfo->pseudo_header
    if you need to construct an ATM pseudo-header for a dissector; have your
    own struct atm_phdr structure, fill it in, and pass a pointer to *that*
    to the sub-dissector.
    
    Cleans things up a bit.
    
    Change-Id: I4464924def4de41c625002b2d273592bd529e46e
    Reviewed-on: https://code.wireshark.org/review/13270
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  7c2eaef   Qt: Show the horizontal scrollbar in the packet detail.
    adds  d9da77a   Have various ATM dissectors use the data arguments for pseudo-headers.


Summary of changes:
 epan/dissectors/packet-atm.c              |  140 +++++++++++-----------
 epan/dissectors/packet-catapult-dct2000.c |    4 +-
 epan/dissectors/packet-erf.c              |  184 ++++++++++++++---------------
 epan/dissectors/packet-fp_hint.c          |   25 ++--
 epan/dissectors/packet-meta.c             |   53 +++++----
 epan/dissectors/packet-pw-atm.c           |   61 ++++------
 6 files changed, 233 insertions(+), 234 deletions(-)