Wireshark-commits: [Wireshark-commits] master-2.0 6067ca3: Qt: Show the horizontal scrollbar in the
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 13 Jan 2016 21:31:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6067ca3ede811ad9ad310355aab90a7807380b39
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

6067ca3 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Show the horizontal scrollbar in the packet detail.
    
    Call resizeColumnToContents when we fill, clear, expand, or contract
    items. This make sure the horizontal scrollbar shows up instead of
    eliding items.
    
    A commonly suggested solution is to call
    header()->setSectionResizeMode(QHeaderView::ResizeToContents) followed
    by header()->setStretchLastSection(false). This makes the scroll bar
    show up when the tree is wider than the window, but when the column is
    narrower than the window we end up with unused white space on the right.
    
    Change-Id: I5896f6048385bed27858f0ac676b29a1bf1255cd
    Reviewed-on: https://code.wireshark.org/review/13265
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 7c2eaefd07e2fb68ae8603c72e1151e5a81dd1b6)
    Reviewed-on: https://code.wireshark.org/review/13268
    

Actions performed:

    from  d015d0c   Qt: Update some keyboard shortcuts to match the GTK+ UI.
    adds  6067ca3   Qt: Show the horizontal scrollbar in the packet detail.


Summary of changes:
 ui/qt/proto_tree.cpp |    8 ++++++++
 1 file changed, 8 insertions(+)