Wireshark-commits: [Wireshark-commits] master fda44fa: Fix some memory leaks in ws80211_utils
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 13 Jan 2016 07:35:32 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fda44fa1fd70cec4b47e11c959b2e04d62ebc0ce
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fda44fa by Mikael Kanstrup (mikael.kanstrup@xxxxxxxxx):

    Fix some memory leaks in ws80211_utils
    
    Valgrind report memleaks like these when using the wireless
    toolbar to create a monitor interface and/or changing channel:
    
    4,168 (72 direct, 4,096 indirect) bytes in 1 blocks are definitely lost in loss record 31 of 32
       at 0x4C2CC70: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
       by 0x5BD0742: ??? (in /lib/x86_64-linux-gnu/libnl-3.so.200.16.1)
       by 0x116308: ws80211_create_on_demand_interface (ws80211_utils.c:699)
       by 0x116308: ws80211_set_freq (ws80211_utils.c:729)
       by 0x10D70E: set_80211_channel (dumpcap.c:4262)
       by 0x10D70E: main (dumpcap.c:4935)
    
    4,168 (72 direct, 4,096 indirect) bytes in 1 blocks are definitely lost in loss record 32 of 32
       at 0x4C2CC70: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
       by 0x5BD0742: ??? (in /lib/x86_64-linux-gnu/libnl-3.so.200.16.1)
       by 0x116400: ws80211_set_freq (ws80211_utils.c:733)
       by 0x10D70E: set_80211_channel (dumpcap.c:4262)
       by 0x10D70E: main (dumpcap.c:4935)
    
    Change-Id: Ia1de630859d96653310fbb3efebdc439ebf107b8
    Reviewed-on: https://code.wireshark.org/review/13237
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  1f0c9f6   Qt: Update some keyboard shortcuts to match the GTK+ UI.
    adds  fda44fa   Fix some memory leaks in ws80211_utils


Summary of changes:
 caputils/ws80211_utils.c |    4 ++++
 1 file changed, 4 insertions(+)