Wireshark-commits: [Wireshark-commits] master-2.0 71f506e: Assorted cleanups.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=71f506ecf793946da9188b147a7b20d2061d9863
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark
Commits:
71f506e by Guy Harris (guy@xxxxxxxxxxxx):
Assorted cleanups.
Fix indentation.
Just directly assign values to elements in the packet buffer; no need to
convert them to numbers and note the value as a comment.
Give more detail in the comment for null-terminating buffers. Terminate
packet_buf[] once we're finished reading into it, to make it a bit
clearer what's being done.
Make the magic number buffer 513 bytes, so we have 512 bytes plus a
terminating null.
Change-Id: Ie182d93393cc55835b24075e908393c386c85c24
Reviewed-on: https://code.wireshark.org/review/13250
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
(cherry picked from commit b7dc77312720bb1bfa3698f3b48e21c991c49632)
Reviewed-on: https://code.wireshark.org/review/13253
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 10d4c85 nettrace_3gpp_32_423 Protect from buffer overun.
adds 71f506e Assorted cleanups.
Summary of changes:
wiretap/nettrace_3gpp_32_423.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)