Wireshark-commits: [Wireshark-commits] master c1d447f: Remove unneeded "#if 0"ed out code.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 4 Jan 2016 21:31:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c1d447fc88cb64a6f8db11eff87f910a15b963bd
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c1d447f by Guy Harris (guy@xxxxxxxxxxxx):

    Remove unneeded "#if 0"ed out code.
    
    If we ever need to look at the value of any field in the packet, we
    should do it the way we do in the RTP analysis code, rather than walking
    the entire protocol tree.
    
    Get rid of an unnecessary extra level of indirection for the filter
    string.
    
    Change-Id: Ie95c0171da79e7f24019a3f67396f6a533959881
    Reviewed-on: https://code.wireshark.org/review/13046
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  cdf9943   Don't walk the entire protocol tree to extract the value of one field.
    adds  c1d447f   Remove unneeded "#if 0"ed out code.


Summary of changes:
 ui/gtk/iax2_analysis.c         |   90 +++----------------------------------
 ui/qt/iax2_analysis_dialog.cpp |   95 +++++-----------------------------------
 2 files changed, 16 insertions(+), 169 deletions(-)