Wireshark · Wireshark-commits: [Wireshark-commits] master cdf9943: Don't walk the entire protocol tree to extract the value of one

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cdf9943717c9bb1cba7af381507b295b384e800b
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cdf9943 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't walk the entire protocol tree to extract the value of one field.
    
    Instead, prime the epan_dissect_t's tree to look for rtp.ssrc, and
    extract that value with proto_get_finfo_ptr_array().
    
    Also, have the filter used to check whether the packet is a candidate
    for RTP analysis to check for RTPv2 (and add a check for IPv4 or IPv6
    back to the Qt version), and get rid of an unnecessary extra level of
    indirection for that string.
    
    In the Qt version, if findStreams() set the error string, don't
    overwrite it with a "No streams found." indication, and fix error
    handling for the "filter didn't compile" case.
    
    Change-Id: I09d0ea37ccd4806d99e3b6394f2a8a376e974705
    Reviewed-on: https://code.wireshark.org/review/13045
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  849d87a   PPP: fix registration of CRTP (CNTCP) protocol
    adds  cdf9943   Don't walk the entire protocol tree to extract the value of one field.


Summary of changes:
 debian/libwireshark0.symbols  |    1 +
 epan/epan.c                   |    8 ++-
 epan/epan.h                   |    7 ++-
 epan/proto.h                  |    2 +-
 ui/gtk/rtp_analysis.c         |  102 ++++++++-----------------------------
 ui/qt/rtp_analysis_dialog.cpp |  112 +++++++++--------------------------------
 6 files changed, 61 insertions(+), 171 deletions(-)