Wireshark-commits: [Wireshark-commits] master 7b10256: Profinet: All SubframeData elements are not
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 25 Nov 2015 08:29:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7b1025624dd339f8ed653b7087bf5c7720b63c79
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7b10256 by Birol Capa (birol.capa@xxxxxxxxxxx):

    Profinet: All SubframeData elements are not decoded
    
    In PDevData/PDirSubframeData/SubframeBlock, not all SubframeData elements are decoded/shown.
    However, all bytes of the SubframeBlock are highlighted in the binary stream correctly.
    
    Change-Id: Ic69999dff524e2e0c48a619def111c4bf9cca5e1
    Reviewed-on: https://code.wireshark.org/review/12100
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  1c7b949   Use try_val_to_str_ext() in print_uuid().
    adds  7b10256   Profinet: All SubframeData elements are not decoded


Summary of changes:
 plugins/profinet/packet-dcerpc-pn-io.c |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)