Wireshark-commits: [Wireshark-commits] master 1c7b949: Use try_val_to_str_ext() in print_uuid().
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 25 Nov 2015 06:21:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1c7b9492906835e81879f93fab940077aeab8dae
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1c7b949 by Guy Harris (guy@xxxxxxxxxxxx):

    Use try_val_to_str_ext() in print_uuid().
    
    That's a much cleaner way of determining whether you found no matchin
    bluetooth_uuid_vals_ext than checking whether val_to_str_ext_const()
    returned the "use this if unknown" value.
    
    It also lets us avoid a wmem_strdup().
    
    Make print_numeric_uuid() and print_uuid() return const gchar *; there's
    no reason for them *not* to be const, and that means we don't have to
    throw away constness.
    
    Change-Id: I62fb0b81c64c107dfea6c16ca8c5b9593f8f2a9d
    Reviewed-on: https://code.wireshark.org/review/12126
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  b1230ba   Fix typo.
    adds  1c7b949   Use try_val_to_str_ext() in print_uuid().


Summary of changes:
 epan/dissectors/packet-bluetooth.c |   31 +++++++++++++++++++++----------
 epan/dissectors/packet-bluetooth.h |    4 ++--
 epan/dissectors/packet-btsdp.c     |    4 ++--
 3 files changed, 25 insertions(+), 14 deletions(-)