Wireshark-commits: [Wireshark-commits] master 759bfb6: Do not expand packets in packet dialog by de
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 22 Nov 2015 11:26:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=759bfb6c45185c06be146b0705465e5560069dff
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

759bfb6 by Peter Wu (peter@xxxxxxxxxxxxx):

    Do not expand packets in packet dialog by default
    
    Do not expand the packet tree in the packet dialog by default, it
    results in forgetting the previous collapse state and deviates from
    previous GTK+ behavior. It is just annoying to have all Frame, Ethernet,
    etc. trees expanded while you are just looking at application layer
    traffic.
    
    (The previous tree is restored when calling ProtoTree::fillProtocolTree
    which calls proto_tree_draw_node and then invokes setExpanded()).
    
    Bug: 11731
    Change-Id: I48c7f28a1777874b1c23025335305493777bca1d
    Reviewed-on: https://code.wireshark.org/review/11998
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  74247f9   Fix RTP player crash on invalid streams
    adds  759bfb6   Do not expand packets in packet dialog by default


Summary of changes:
 ui/qt/packet_dialog.cpp |    1 -
 1 file changed, 1 deletion(-)