Wireshark-commits: [Wireshark-commits] master-2.0 402735d: Fix RTP player crash on invalid streams
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 22 Nov 2015 11:25:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=402735d3488b6f9e84b648a64b7cf6a2a0d06c5f
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

402735d by Peter Wu (peter@xxxxxxxxxxxxx):

    Fix RTP player crash on invalid streams
    
    On Linux with pulseaudio, the RTP player can crash when an invalid RTP
    stream is played. Prevent that by detecting when stream playback fails.
    
    Since the stateChanged signal receiver is registered on the same
    thread, it is guaranteed that any outputStateChanged calls happen before
    returning from audio_output_->start().
    
    GTK+ not have this issue, its player simply does not show the decoded
    stream at all.
    
    Change-Id: I51a91a7f410ef3d46551bc8df0049542efbb806f
    Reviewed-on: https://code.wireshark.org/review/11997
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 74247f96a998797e933f09f566f60406b9ba92b4)
    Reviewed-on: https://code.wireshark.org/review/12029
    

Actions performed:

    from  f5bad76   SCSI: Fix mixed up SCSI senddiag PF values
    adds  402735d   Fix RTP player crash on invalid streams


Summary of changes:
 ui/qt/rtp_audio_stream.cpp |    5 +++++
 1 file changed, 5 insertions(+)