Wireshark · Wireshark-commits: [Wireshark-commits] master-2.0 f13254a: Lua: Validate Proto() arguments

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f13254aaf04c20d2fc8cdac1335597800ef9fe07
Submitter: Stig Bj?rlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

f13254a by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Lua: Validate Proto() arguments
    
    Check if description (protocol name) and short_name are used before
    registering the protocol.  This because proto_register_protocol() makes
    sure there's not already a protocol with any of the names registered
    and duplicates will be reported with a g_error() which terminates the
    Wireshark unexpectedly.
    
    Also check if short_name contains valid characters.
    
    Give appropriate error messages.
    
    Bug: 11739
    Change-Id: Ib9776a2a3406ae5278ce744defd61864ebed0282
    Reviewed-on: https://code.wireshark.org/review/11995
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/12019
    

Actions performed:

    from  1e4b183   debian: Move icon and mime info file to wireshark-common
    adds  f13254a   Lua: Validate Proto() arguments


Summary of changes:
 debian/libwireshark6.symbols |    1 +
 epan/proto.c                 |   13 +++++++++++++
 epan/proto.h                 |    5 +++++
 epan/wslua/wslua_proto.c     |   19 +++++++++++++++----
 4 files changed, 34 insertions(+), 4 deletions(-)