Wireshark-commits: [Wireshark-commits] master 94b9907: Lua: Validate Proto() arguments
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 21 Nov 2015 20:30:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=94b9907d0f32fe4d570d94b820b20b6906a21499
Submitter: Stig Bj?rlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

94b9907 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Lua: Validate Proto() arguments
    
    Check if description (protocol name) and short_name are used before
    registering the protocol.  This because proto_register_protocol() makes
    sure there's not already a protocol with any of the names registered
    and duplicates will be reported with a g_error() which terminates the
    Wireshark unexpectedly.
    
    Also check if short_name contains valid characters.
    
    Give appropriate error messages.
    
    Bug: 11739
    Change-Id: Ib9776a2a3406ae5278ce744defd61864ebed0282
    Reviewed-on: https://code.wireshark.org/review/11995
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  23258fb   epan: Removed an unneeded g_malloc.
    adds  94b9907   Lua: Validate Proto() arguments


Summary of changes:
 debian/libwireshark0.symbols |    1 +
 epan/proto.c                 |   13 +++++++++++++
 epan/proto.h                 |    5 +++++
 epan/wslua/wslua_proto.c     |   19 +++++++++++++++----
 4 files changed, 34 insertions(+), 4 deletions(-)