Wireshark · Wireshark-commits: [Wireshark-commits] master-2.0 8fdef73: Treat "-" as "standard input" in the CLI, not in libwiretap.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8fdef73faafcd1eb0e198b3f5444a809e7fb6c11
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

8fdef73 by Guy Harris (guy@xxxxxxxxxxxx):

    Treat "-" as "standard input" in the CLI, not in libwiretap.
    
    That's a UI convention, and the GUI shouldn't honor that convention - a
    user might get confused if they try to save to "-" and end up with
    nothing (and with a ton of crap in a log file if programs launched from
    the GUI end up with their standard output and error logged).
    
    While we're at it, make randcap report write and close errors.
    
    Change-Id: I6ea0a486864da71ecbb98501c96b98cd3bc424cb
    Reviewed-on: https://code.wireshark.org/review/11667
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f824a84   Update tests to reflect Lua file API change (write_close -> write_finish).
    adds  8fdef73   Treat "-" as "standard input" in the CLI, not in libwiretap.


Summary of changes:
 editcap.c             |   39 +++++++++++++++++++-----
 randpkt.c             |   79 +++++++++++++++++++++++++++++++++++++++++++++----
 reordercap.c          |   12 ++++++--
 tshark.c              |   20 ++++++++++---
 wiretap/file_access.c |   36 ++++++----------------
 5 files changed, 138 insertions(+), 48 deletions(-)