Wireshark-commits: [Wireshark-commits] master 6c3c6de: Treat "-" as "standard input" in the CLI, no
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 Nov 2015 01:23:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6c3c6de340ff2016b06c0081c6c822c723d40f80
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6c3c6de by Guy Harris (guy@xxxxxxxxxxxx):

    Treat "-" as "standard input" in the CLI, not in libwiretap.
    
    That's a UI convention, and the GUI shouldn't honor that convention - a
    user might get confused if they try to save to "-" and end up with
    nothing (and with a ton of crap in a log file if programs launched from
    the GUI end up with their standard output and error logged).
    
    While we're at it, make randcap report write and close errors.
    
    Change-Id: I9c450f0ca0320ce4c36d13d209b56d72edb43012
    Reviewed-on: https://code.wireshark.org/review/11666
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  411112a   packet-smb2: provide reassembling support for Named Pipe subdissectors (e.g. DCERPC)
    adds  6c3c6de   Treat "-" as "standard input" in the CLI, not in libwiretap.


Summary of changes:
 editcap.c             |   39 +++++++++---
 randpkt.c             |  163 ++++++++++++++++++++++++++++++++++++++-----------
 reordercap.c          |   12 +++-
 tshark.c              |   20 ++++--
 wiretap/file_access.c |   36 +++--------
 5 files changed, 192 insertions(+), 78 deletions(-)