Wireshark-commits: [Wireshark-commits] master 24bfb7e: column-utils: Refactor col_append_port() to
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 7 Nov 2015 21:15:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=24bfb7e35d619c004e0458f38a1d5ae538a898fb
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

24bfb7e by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    column-utils: Refactor col_append_port() to col_append_ports()
    
    Having a single function call to format source-destination port column info serves the
    current (and presently only) use case better by having a single place to manage the
    display format.
    
    This commit does not introduce any actual formatting changes.
    
    Change-Id: I1d479d0fd5690d12afb47e538057fdc2dd369ca2
    Reviewed-on: https://code.wireshark.org/review/11539
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  31f004f   Further refactor GSS_API dissectors to pass gssapi_encrypt_info_t structure between dissectors instead of using packet_info.h The only remaining explicit user of the packet_info members is the NTLMSSP dissector.  However, there may be "hidden" use of it in the spnego dissector passing between ASN.1 functions. Someone more familiar with the protocols could possibly trim some of the "extra copies" between packet_info and gssapi_encrypt_info_t structure, but I went the "b [...]
    adds  24bfb7e   column-utils: Refactor col_append_port() to col_append_ports()


Summary of changes:
 debian/libwireshark0.symbols  |    2 +-
 epan/column-utils.c           |   23 +++++++++++++++++------
 epan/column-utils.h           |   10 +++++-----
 epan/dissectors/packet-dccp.c |    4 +---
 epan/dissectors/packet-tcp.c  |    4 +---
 epan/dissectors/packet-udp.c  |    4 +---
 6 files changed, 26 insertions(+), 21 deletions(-)