Wireshark-commits: [Wireshark-commits] master 31f004f: Further refactor GSS_API dissectors to pass
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 7 Nov 2015 21:13:22 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=31f004f1caee87d744610f48c93fae1efa8e7b56
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

31f004f by Michael Mann (mmann78@xxxxxxxxxxxx):

    Further refactor GSS_API dissectors to pass gssapi_encrypt_info_t structure between dissectors instead of using packet_info.h
    The only remaining explicit user of the packet_info members is the NTLMSSP dissector.  However, there may be "hidden" use of it in the spnego dissector passing between ASN.1 functions.
    Someone more familiar with the protocols could possibly trim some of the "extra copies" between packet_info and gssapi_encrypt_info_t structure, but I went the "better safe than sorry" route.
    
    Change-Id: I160d2cfccadc5f49b128609223cdff0162c3ca85
    Reviewed-on: https://code.wireshark.org/review/11575
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  e6a2f17   Add user preference to display IPv6 ext headers under root protocol tree
    adds  31f004f   Further refactor GSS_API dissectors to pass gssapi_encrypt_info_t structure between dissectors instead of using packet_info.h The only remaining explicit user of the packet_info members is the NTLMSSP dissector.  However, there may be "hidden" use of it in the spnego dissector passing between ASN.1 functions. Someone more familiar with the protocols could possibly trim some of the "extra copies" between packet_info and gssapi_encrypt_info_t structure, but I went the "b [...]


Summary of changes:
 asn1/kerberos/packet-kerberos-template.h |   35 ++++
 asn1/spnego/packet-spnego-template.c     |  251 ++++++++++++++++++++---------
 epan/dissectors/packet-gssapi.c          |   59 ++++---
 epan/dissectors/packet-gssapi.h          |    3 +
 epan/dissectors/packet-kerberos.h        |   37 ++++-
 epan/dissectors/packet-rpc.c             |   35 ++--
 epan/dissectors/packet-spnego.c          |  255 +++++++++++++++++++++---------
 epan/packet_info.h                       |    2 -
 8 files changed, 483 insertions(+), 194 deletions(-)