Wireshark-commits: [Wireshark-commits] master ce22578: Don't include io.h in Flex scanners - they'r
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ce2257899647c3980ad1493bdade0d81f2d2f17f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
ce22578 by Guy Harris (guy@xxxxxxxxxxxx):
Don't include io.h in Flex scanners - they're not interactive.
We don't have any Flex scanners that support an interactive command-line
interface, so none of our scanners are, or need to be, interactive.
Mark text2pcap's scanner as not interactive.
That means none of our scanners should call isatty(), so they don't have
any need to include <io.h> on Windows; remove that include from the
Lucent/Ascent text capture scanner.
Update a comment to reflect that what matters isn't whether we can read
from a terminal or whether we actually do so, what matters is whether
they read *interactively* from a terminal (if you want to run text2pcap
reading from the standard input and type at it, be my guest).
Change-Id: I59979d1fdb37e1913125a400963ff7a3fa6b9bbd
Reviewed-on: https://code.wireshark.org/review/11587
Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from d02104c Qt: Check for a sane window geometry.
adds ce22578 Don't include io.h in Flex scanners - they're not interactive.
Summary of changes:
epan/dfilter/scanner.l | 2 +-
epan/diam_dict.l | 2 +-
epan/dtd_parse.l | 2 +-
epan/dtd_preparse.l | 2 +-
epan/radius_dict.l | 2 +-
epan/uat_load.l | 2 +-
plugins/mate/mate_parser.l | 2 +-
plugins/wimaxasncp/wimaxasncp_dict.l | 2 +-
text2pcap-scanner.l | 5 +++++
ui/text_import_scanner.l | 2 +-
wiretap/ascend_scanner.l | 6 +-----
wiretap/k12text.l | 2 +-
12 files changed, 16 insertions(+), 15 deletions(-)
