Wireshark-commits: [Wireshark-commits] master-2.0 0d0302e: Qt: Check for a sane window geometry.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0d0302ea432c8819a5af4603596842a347d08b39
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark
Commits:
0d0302e by Gerald Combs (gerald@xxxxxxxxxxxxx):
Qt: Check for a sane window geometry.
On Windows (and probably X11) it's possible to set an offscreen window
geometry. Add a rect_on_screen function to qt_ui_utils and use it as a
sanity check in MainWindow::loadWindowGeometry.
If this doesn't work well (e.g. if we end up with dueling Qt and GTK+
geometries) we might want to create separate Qt and GTK+ preferences.
Bug: 11568
Change-Id: Icde1181671770356e87f07d584894ec3148e1bd2
Reviewed-on: https://code.wireshark.org/review/11584
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
(cherry picked from commit d02104c9a61c353ce6ed54c6ca6207ed3a1fcdf0)
Reviewed-on: https://code.wireshark.org/review/11588
Actions performed:
from fa85852 docs: Windows CMake builds
adds 0d0302e Qt: Check for a sane window geometry.
Summary of changes:
ui/qt/main_window.cpp | 17 ++++++++++++-----
ui/qt/qt_ui_utils.cpp | 12 ++++++++++++
ui/qt/qt_ui_utils.h | 9 +++++++++
3 files changed, 33 insertions(+), 5 deletions(-)