Wireshark-commits: [Wireshark-commits] master f52d1d5: wslua: do not pop from empty stack on newer
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 30 Sep 2015 12:32:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f52d1d52a6247aa04dc328d081736b387ad8be6c
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f52d1d5 by Peter Wu (peter@xxxxxxxxxxxxx):

    wslua: do not pop from empty stack on newer LUA versions
    
    Fixes this failure:
    
        tshark: lapi.c:175: lua_settop: Assertion `(-(idx+1) <= (L->top - (func + 1))) && "invalid new top"' failed.
    
    Found using LUA 5.2 compiled with -DLUA_USE_APICHECK. Note that the
    value returned by luaopen_bit does not affect the size of the stack
    after using lua_call; if there are excess return values, then these will
    be dropped after calling lua_call. See http://www.lua.org/pil/26.2.html
    
    I also verified that the stack is still empty after calling all
    wslua_reg_module functions.
    
    Change-Id: Ia72635277ca4d8077e47a5c472391a78fe6d311e
    Reviewed-on: https://code.wireshark.org/review/10664
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  01bd832   gtk: Fix crash on Analyze RTP stream
    adds  f52d1d5   wslua: do not pop from empty stack on newer LUA versions


Summary of changes:
 epan/wslua/make-reg.pl |    2 --
 1 file changed, 2 deletions(-)