Wireshark-commits: [Wireshark-commits] master 01bd832: gtk: Fix crash on Analyze RTP stream
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 30 Sep 2015 12:28:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=01bd832b9df9570ddfd81ab4985f71ff6abd9b12
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

01bd832 by Peter Wu (peter@xxxxxxxxxxxxx):

    gtk: Fix crash on Analyze RTP stream
    
    When updating the RTP streams list, the data associated with the current
    selection becomes invalid when the old list is cleared.
    gtk_list_store_clear somehow triggers the selection callback which
    attempts to access the invalid memory.
    
    Avoid this by disabling selectability while clearing the list.
    
    Bug: 10016
    Change-Id: Id5126ec5ffa41fa6a65339f4453546223124ed67
    Reviewed-on: https://code.wireshark.org/review/10690
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  6ac0d84   nwp: add support for NWP packets
    adds  01bd832   gtk: Fix crash on Analyze RTP stream


Summary of changes:
 ui/gtk/rtp_stream_dlg.c |    6 ++++++
 1 file changed, 6 insertions(+)