Wireshark · Wireshark-commits: [Wireshark-commits] master 0af048b: Remove calls of tvb_ensure_length_remaining.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0af048b7e40ee92d6702df873cbc515ae2eff9c8
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0af048b by Michael Mann (mmann78@xxxxxxxxxxxx):

    Remove calls of tvb_ensure_length_remaining.
    
    The remaining calls seem to fall into 3 categories:
    1. passing it to tvb_find_line_end when -1 (for length) will do.
    2. duplicating the checking of tvb_reported_length_remaining, which is already in use near the tvb_ensure_length_remaining call.
    3. Those that (probably) need tvb_ensure_capture_length_remaining
    
    Change-Id: I1e77695251e055644bcbbb89f3c181c65d1671ca
    Reviewed-on: https://code.wireshark.org/review/10268
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  374439d   Don't emit app signals from dialogs.
    adds  0af048b   Remove calls of tvb_ensure_length_remaining.


Summary of changes:
 epan/dissectors/packet-l1-events.c  |    7 ++-----
 epan/dissectors/packet-ldss.c       |    4 +---
 epan/dissectors/packet-memcache.c   |   16 +++++-----------
 epan/dissectors/packet-nbt.c        |   14 +-------------
 epan/dissectors/packet-rtsp.c       |   10 +++-------
 epan/dissectors/packet-ssh.c        |   12 ++++++------
 epan/dissectors/packet-syslog.c     |    2 +-
 epan/dissectors/packet-tds.c        |    4 +---
 epan/dissectors/packet-text-media.c |    4 +---
 epan/dissectors/packet-x11.c        |   21 ++-------------------
 epan/dissectors/packet-xcsl.c       |    7 +------
 epan/tvbuff.h                       |    3 ---
 tools/checkAPIs.pl                  |    1 -
 13 files changed, 24 insertions(+), 81 deletions(-)