Wireshark · Wireshark-commits: [Wireshark-commits] master 374439d: Don't emit app signals from dialogs.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=374439daa17fe2692746857b920616354ce658e7
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

374439d by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Don't emit app signals from dialogs.
    
    Emitting PacketDissectionChanged from a dialog on can render the main
    window unusable on OS X. A workaround for this was added to the
    preferences dialog in g8fc2327. Generalize the workaround and use it
    elsewhere.
    
    Fix the "Enabled Protocols" action name while we're here.
    
    Bug: 11361
    Bug: 11448
    Change-Id: I89e98daaaedc877d3b13b0d33b6f3be033e323d7
    Reviewed-on: https://code.wireshark.org/review/10271
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  8ad5611   sv: remove some unnecessary checks
    adds  374439d   Don't emit app signals from dialogs.


Summary of changes:
 ui/qt/decode_as_dialog.cpp             |    2 +-
 ui/qt/enabled_protocols_dialog.cpp     |   12 ++++++++----
 ui/qt/enabled_protocols_dialog.h       |    2 ++
 ui/qt/enabled_protocols_dialog.ui      |    2 +-
 ui/qt/main_window.ui                   |    2 +-
 ui/qt/main_window_slots.cpp            |   27 +++++++++++++++++----------
 ui/qt/preferences_dialog.cpp           |    7 ++-----
 ui/qt/preferences_dialog.h             |    3 ---
 ui/qt/protocol_preferences_menu.cpp    |    3 +++
 ui/qt/sctp_chunk_statistics_dialog.cpp |    4 ++++
 ui/qt/uat_dialog.cpp                   |    4 ++--
 ui/qt/wireshark_application.cpp        |   20 ++++++++++++++++++++
 ui/qt/wireshark_application.h          |    8 ++++++++
 13 files changed, 69 insertions(+), 27 deletions(-)