Wireshark-commits: [Wireshark-commits] master 9d5a9fb: Don't put the NTLMv2 ChallengeFromClient int
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 18 May 2015 17:18:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9d5a9fb1ff462646e04cb52971bfa7c16993d93b
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9d5a9fb by Guy Harris (guy@xxxxxxxxxxxx):

    Don't put the NTLMv2 ChallengeFromClient into the protocol tree twice.
    
    It's already put there by dissect_ntlmv2_response(); no need to do it
    again.
    
    Also, rename "NTLM Client Challenge" to "LMv2 Client Challenge", as
    that's what it is (ChallengeFromClient from 2.2.2.4 LMv2_RESPONSE), and
    rename "Client Challenge" to "NTLMv2 Client Challenge", as that's what
    *it* is (ChallengeFromClient from 2.2.2.7 NTLM v2:
    NTLMv2_CLIENT_CHALLENGE).
    
    Change-Id: If95e2c77323cb597df7e400bf9ffc045d94c60e2
    Reviewed-on: https://code.wireshark.org/review/8524
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  65b17d4   Reorganize the NTLMSSP blob and AUTHENTICATE message parsing.
    adds  9d5a9fb   Don't put the NTLMv2 ChallengeFromClient into the protocol tree twice.


Summary of changes:
 epan/dissectors/packet-ntlmssp.c |   14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)