Wireshark-commits: [Wireshark-commits] master 65b17d4: Reorganize the NTLMSSP blob and AUTHENTICATE
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 18 May 2015 17:01:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=65b17d4323e01add3db1b48e1f95b6fe02732177
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

65b17d4 by Guy Harris (guy@xxxxxxxxxxxx):

    Reorganize the NTLMSSP blob and AUTHENTICATE message parsing.
    
    The "result" argument to dissect_ntlmssp_blob() is never null, so don't
    check for it being null.
    
    Have separate clauses for LmChallengeResponse and NtChallengeResponse,
    and do the checks for NTLMv1 vs. NTLMv2 inside those clauses.
    
    Do the copy to client_challenge within the AUTHENTICATE message parsing
    only if we've already determined that it's an NTLMv2 message.
    
    Add some comments to better explain what's being done and to ask some
    questions.
    
    Change-Id: I52345eaeac4252d928b2e477751817084bf4e363
    Reviewed-on: https://code.wireshark.org/review/8523
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  930f5b5   Bluetooth: OBEX: Fix crash when there is no Type/Name header in request
    adds  65b17d4   Reorganize the NTLMSSP blob and AUTHENTICATE message parsing.


Summary of changes:
 epan/dissectors/packet-ntlmssp.c |  108 +++++++++++++++++++++++++++-----------
 1 file changed, 78 insertions(+), 30 deletions(-)