Wireshark-commits: [Wireshark-commits] master 8045cd6: Do not assume the data field of an address s
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 11 May 2015 22:11:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8045cd648140cf56ef8b9c02f1015b8807082333
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8045cd6 by Guy Harris (guy@xxxxxxxxxxxx):

    Do not assume the data field of an address structure is an aligned pointer.
    
    There is *no* guarantee that it's aligned on a 4-byte boundary, and
    there is *no* guarantee that you can safely dereference an unaligned
    pointer.  See bug 11172 for a crash on Solaris/SPARC caused by those
    assumptions both being false.
    
    Change-Id: I30d97aebd42283545f5b8f6d50fa09c5b476ec47
    Reviewed-on: https://code.wireshark.org/review/8412
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  e3e5d30   Pull the MIMO control code into the beamforming report code.
    adds  8045cd6   Do not assume the data field of an address structure is an aligned pointer.


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)