Wireshark-commits: [Wireshark-commits] master e3e5d30: Pull the MIMO control code into the beamform
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 11 May 2015 21:58:50 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e3e5d3032eea06ea00f7028cb35f559bfd2af186
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e3e5d30 by Guy Harris (guy@xxxxxxxxxxxx):

    Pull the MIMO control code into the beamforming report code.
    
    Hopefully, that'll convince Microsoft's static analyzer that nr will
    always be >= 1, so you can safely subtract 1 from it and use it as an
    array index.
    
    Get rid of the vht_mimo_control_t structure in favor of a few variables
    for the bitfields we actually use.
    
    Make some tables static - no need to initialize them every time we enter
    the routine.
    
    Change-Id: Icde05a768ea1a9c897b69003afcab1dddeffaaf5
    Reviewed-on: https://code.wireshark.org/review/8411
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  9fd6c45   proto: use correct mask when checking display
    adds  e3e5d30   Pull the MIMO control code into the beamforming report code.


Summary of changes:
 epan/dissectors/packet-ieee80211.c |  109 +++++++++++++++---------------------
 1 file changed, 46 insertions(+), 63 deletions(-)