Wireshark-commits: [Wireshark-commits] master acf7985: Define the SHA-1 digest length in wsutil/sha
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 9 May 2015 23:36:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=acf7985f7377806e23d7ec9daa14a3a6886a51c7
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

acf7985 by Guy Harris (guy@xxxxxxxxxxxx):

    Define the SHA-1 digest length in wsutil/sha1.h and use it.
    
    Hopefully that'll make it a little easier to make sure that we're not
    overflowing arrays.
    
    Change-Id: I770df045ef9a45fd486c1271ea424b3334bb39d2
    Reviewed-on: https://code.wireshark.org/review/8370
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  bb89e77   Make option_content a guint8 *.
    adds  acf7985   Define the SHA-1 digest length in wsutil/sha1.h and use it.


Summary of changes:
 asn1/cms/packet-cms-template.c             |    5 ++---
 asn1/snmp/packet-snmp-template.c           |    8 ++++----
 epan/crypt/airpdcap.c                      |   18 ++++++++---------
 epan/dissectors/packet-cms.c               |   13 ++++++-------
 epan/dissectors/packet-corosync-totemnet.c |   29 ++++++++++++++--------------
 epan/dissectors/packet-l2tp.c              |    9 ++++-----
 epan/dissectors/packet-sigcomp.c           |    4 ++--
 epan/dissectors/packet-snmp.c              |    8 ++++----
 wsutil/sha1.c                              |   16 +++++++--------
 wsutil/sha1.h                              |   11 ++++++++---
 10 files changed, 60 insertions(+), 61 deletions(-)