Wireshark-commits: [Wireshark-commits] master bb89e77: Make option_content a guint8 *.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 9 May 2015 19:36:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bb89e7724220098e7b7fba5d31daf0d916b2d553
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bb89e77 by Guy Harris (guy@xxxxxxxxxxxx):

    Make option_content a guint8 *.
    
    It points to an array of bytes, not a character string.
    
    Add some casts to squelch other Sun/Oracle C warnings.
    
    Clean up some comments while we're at it.
    
    Change-Id: Id0908178cb00d537e95569b9ce6f745c8fd6d716
    Reviewed-on: https://code.wireshark.org/review/8369
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  89f0c5e   ICMP: Fix Logically dead code (CID 1295678)
    adds  bb89e77   Make option_content a guint8 *.


Summary of changes:
 wiretap/pcapng.c |   88 ++++++++++++++++++++++++++++++------------------------
 1 file changed, 49 insertions(+), 39 deletions(-)