Wireshark-commits: [Wireshark-commits] master-1.12 dd17731: Don't use WTAP_ERR_UNSUPPORTED for unwr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 18 Dec 2014 00:22:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dd1773166c86b3a365cb844137da90f5c4be459c
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

dd17731 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use WTAP_ERR_UNSUPPORTED for unwritable records.
    
    WTAP_ERR_UNSUPPORTED is expected to include an err_info string;
    WTAP_ERR_UNSUPPORTED_ENCAP isn't.  In the trunk, we use a new error code
    for that, and supply and process the err_info string; here, we just use
    WTAP_ERR_UNSUPPORTED_ENCAP, so we don't have to make as extensive changes.
    
    Change-Id: I6f02238c178aff8e277bfc977c8b941d8e5ebea2
    Reviewed-on: https://code.wireshark.org/review/5824
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  e2793f5   HiSLIP: disable heuristic dissector by default
    adds  dd17731   Don't use WTAP_ERR_UNSUPPORTED for unwritable records.


Summary of changes:
 wiretap/btsnoop.c |    2 +-
 wiretap/logcat.c  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)