Wireshark-commits: [Wireshark-commits] master 51522b3: Handle "I can't map this for that file forma
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 18 Dec 2014 00:03:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=51522b33723dec4dd0481dcabc261010be39937c
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

51522b3 by Guy Harris (guy@xxxxxxxxxxxx):

    Handle "I can't map this for that file format" better.
    
    For cases where record (meta)data is something that can't be written out
    in a particular file format, return WTAP_ERR_UNWRITABLE_REC_DATA along
    with an err_info string.
    
    Report (and free) that err_info string in cases where
    WTAP_ERR_UNWRITABLE_REC_DATA is returned.
    
    Clean up some other error reporting cases, and flag with an XXX some
    cases where we aren't reporting errors at all, while we're at it.
    
    Change-Id: I91d02093af0d42c24ec4634c2c773b30f3d39ab3
    Reviewed-on: https://code.wireshark.org/review/5823
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  8ce0f12   Resync Debian symbols Fix wrong symbol for proto_tree_add_bitmask_with_flags
    adds  51522b3   Handle "I can't map this for that file format" better.


Summary of changes:
 capinfos.c                    |    2 ++
 captype.c                     |    1 +
 editcap.c                     |   36 ++++++++++++++++++++++--
 epan/wslua/wslua_dumper.c     |   36 ++++++++++++++++++++----
 epan/wslua/wslua_file.c       |    4 +--
 file.c                        |   61 ++++++++++++++++++++++++++++++++++++++--
 mergecap.c                    |   32 +++++++++++++++++++--
 randpkt.c                     |   14 +++++++++-
 reordercap.c                  |   20 +++++++++++--
 tshark.c                      |   62 +++++++++++++++++++++++++++++++++++++++--
 ui/tap_export_pdu.c           |   13 ++++++++-
 ui/text_import.c              |   14 +++++++++-
 wiretap/5views.c              |    4 +--
 wiretap/btsnoop.c             |   19 ++++++++-----
 wiretap/catapult_dct2000.c    |    4 +--
 wiretap/commview.c            |    4 +--
 wiretap/erf.c                 |    3 +-
 wiretap/eyesdn.c              |    4 +--
 wiretap/file_access.c         |    4 +--
 wiretap/k12.c                 |    2 +-
 wiretap/k12text.l             |    2 +-
 wiretap/lanalyzer.c           |    2 +-
 wiretap/libpcap.c             |    4 +--
 wiretap/logcat.c              |    2 +-
 wiretap/logcat_text.c         |    6 ++--
 wiretap/netmon.c              |    4 +--
 wiretap/netscaler.c           |    4 +--
 wiretap/nettl.c               |    4 +--
 wiretap/network_instruments.c |    4 +--
 wiretap/netxray.c             |    8 +++---
 wiretap/ngsniffer.c           |    4 +--
 wiretap/pcapng.c              |    2 +-
 wiretap/snoop.c               |    4 +--
 wiretap/visual.c              |    4 +--
 wiretap/wtap-int.h            |    2 +-
 wiretap/wtap.c                |    5 +++-
 wiretap/wtap.h                |    6 +++-
 37 files changed, 333 insertions(+), 73 deletions(-)