Wireshark-commits: [Wireshark-commits] master bcaa5d8: Qt: Update and rename the summary dialog.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 9 Dec 2014 19:02:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bcaa5d84b1e6637927faf6066d6e57a92c94146e
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bcaa5d8 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Update and rename the summary dialog.
    
    Go back to a single view similar to the GTK+ UI. Apply layouts using Qt
    Designer.
    
    Rename the menu item and class to "Capture File Properties". It's not
    really a summary if it contains details such as "marked average bits
    per second". We might want to move this to a "Properties" item under
    the "File" menu similar to other applications.
    
    Add the GTK+ summary icon (for now) to the toolbar and open the
    properties dialog on clicking.
    
    Singleton dialogs delenda est[1]. Let the user open as many summaries on
    as many capture files as he or she wishes. Also, global cfile delenda
    est[2].
    
    Don't blindly include QtGui. Add specific components instead.
    
    Use consistent method names, variable names, and patterns. Try to
    document what "consistent" means.
    
    Adjust the way we display some statistics to match the summary bar, e.g.
    displayed = captured if we don't have a filter applied.
    
    [1] Not really.
    [2] Yes, really.
    
    Change-Id: I11793b1d79dd0c3f70414ac8592b86181da59916
    Reviewed-on: https://code.wireshark.org/review/5274
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  9681bdd   Eliminate proto_tree_add_text from packet-ppp.c.
    adds  bcaa5d8   Qt: Update and rename the summary dialog.


Summary of changes:
 doc/README.qt                                      |   25 +-
 docbook/release-notes.asciidoc                     |    1 +
 image/status.qrc                                   |    3 +
 ui/qt/CMakeLists.txt                               |    8 +-
 ui/qt/Makefile.am                                  |    4 +-
 ui/qt/Makefile.common                              |    8 +-
 ui/qt/Wireshark.pro                                |    8 +-
 ui/qt/capture_file_properties_dialog.cpp           |  551 ++++++++++++++
 ...y_dialog.h => capture_file_properties_dialog.h} |   47 +-
 ui/qt/capture_file_properties_dialog.ui            |   74 ++
 ui/qt/follow_stream_dialog.cpp                     |    1 +
 ui/qt/main_status_bar.cpp                          |    8 +-
 ui/qt/main_status_bar.h                            |    5 +-
 ui/qt/main_window.cpp                              |   17 +-
 ui/qt/main_window.h                                |    7 +-
 ui/qt/main_window.ui                               |    9 +-
 ui/qt/main_window_slots.cpp                        |   28 +-
 ui/qt/summary_dialog.cpp                           |  775 --------------------
 ui/qt/summary_dialog.ui                            |  474 ------------
 ui/qt/wireshark_en.ts                              |  168 ++---
 ui/qt/wireshark_fr.ts                              |  168 ++---
 ui/qt/wireshark_it.ts                              |  168 ++---
 ui/qt/wireshark_ja_JP.ts                           |  168 ++---
 ui/qt/wireshark_zh_CN.ts                           |  168 ++---
 24 files changed, 1146 insertions(+), 1747 deletions(-)
 create mode 100644 ui/qt/capture_file_properties_dialog.cpp
 rename ui/qt/{summary_dialog.h => capture_file_properties_dialog.h} (66%)
 create mode 100644 ui/qt/capture_file_properties_dialog.ui
 delete mode 100644 ui/qt/summary_dialog.cpp
 delete mode 100644 ui/qt/summary_dialog.ui