Wireshark-commits: [Wireshark-commits] master 9681bdd: Eliminate proto_tree_add_text from packet-pp
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 9 Dec 2014 18:59:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9681bddaa60fd7cdfdba00ebd87903a860c4166c
Submitter: Christopher Maynard (Christopher.Maynard@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9681bdd by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate proto_tree_add_text from packet-ppp.c.
    
    Some of the conversions to proto_tree_add_xxx calls involved using explicit sizes instead of the "option length", so there is skipping of the "byte highlighting" of the type + length bytes.
    
    Change-Id: Ibfe09a089fb33ba43121de079aca81742d48db4c
    Reviewed-on: https://code.wireshark.org/review/5636
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Christopher Maynard <Christopher.Maynard@xxxxxxxxx>
    

Actions performed:

    from  74172ae   LTE: Update MAC and RLC dissectors to Release 12
    adds  9681bdd   Eliminate proto_tree_add_text from packet-ppp.c.


Summary of changes:
 epan/dissectors/packet-ppp.c |  618 ++++++++++++++++++++++++------------------
 1 file changed, 351 insertions(+), 267 deletions(-)