Wireshark-commits: Re: [Wireshark-commits] master 7143bd7: Do the PCR and the original PCR the same
Thanks for fixing this, I missed the buildbot error.
Would there be any chance to include OS X in the petri dish? I tried
this before pushing and saw no issues on Windows and Linux.
Thus wrote Wireshark code review (code-review-do-not-reply@xxxxxxxxxxxxx):
> URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7143bd72f9bc47f40f07763a9ef32459eaa5b311
> Submitter: Guy Harris (guy@xxxxxxxxxxxx)
> Changed: branch: master
> Repository: wireshark
> Commits:
> 7143bd7 by Guy Harris (guy@xxxxxxxxxxxx):
> Do the PCR and the original PCR the same way.
> In both cases, make the extension a 16-bit variable, cast the result of
> extracting the extension to guint16 to clarify that only the 9 bits
> visible through the mask matter.
> While we're at it, there's no need to use
> "proto_tree_add_uint64_format_value() if the format is just the standard
> format for a 64-bit unsigned integer.
> Change-Id: I8f1f48595830d4672984f3797be1c9d994e64ea0
> Reviewed-on: https://code.wireshark.org/review/4043
> Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
> Actions performed:
> from 4af01a8 don't skip another 6 bytes after OPCR Bug: 10446
> adds 7143bd7 Do the PCR and the original PCR the same way.
> Summary of changes:
> epan/dissectors/packet-mp2t.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
> ___________________________________________________________________________
> Sent via: Wireshark-commits mailing list <wireshark-commits@xxxxxxxxxxxxx>
> Archives: http://www.wireshark.org/lists/wireshark-commits
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
> mailto:wireshark-commits-request@xxxxxxxxxxxxx?subject=unsubscribe
