Wireshark · Wireshark-commits: [Wireshark-commits] master 8f84fe9: Clean up handling of the message type.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8f84fe9d96cefa1004f48d8f9f3bdd93d5f44438
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8f84fe9 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up handling of the message type.
    
    Don't use try_val_to_str() and then never test the result to see whether
    it's null.  Instead, use val_to_str_const().
    
    Don't use proto_tree_add_uint_format_value() to emulate what
    proto_tree_add_uint() does unless the string for the value isn't
    computed from the value_string for the field.
    
    Also, prepend to the Info column as soon as we have the data with which
    to do so.
    
    Change-Id: Iae9bdfc7c80cbd1ec63e1bbb8d43560adec558bd
    Reviewed-on: https://code.wireshark.org/review/4113
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f30bba3   USB feature selectors now per USB 3.1 spec
    adds  8f84fe9   Clean up handling of the message type.


Summary of changes:
 epan/dissectors/packet-edonkey.c |   12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)