Wireshark-commits: [Wireshark-commits] master f91ef6d: General cleanup of RTP-MIDI dissector.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 9 Sep 2014 02:06:46 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f91ef6dd4dd234a624547d93802d53c0540d2c69
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f91ef6d by Michael Mann (mmann78@xxxxxxxxxxxx):

    General cleanup of RTP-MIDI dissector.
    
    The biggest changes involved:
    1. Use the "bounds checking" of proto_tree_add_xxx, instead of doing it manually. There are still places where it's done "manually", but they have been drastically reduced.  Someone with more understanding of the protocol/dissector would need to take a look at them.
    2. proto_tree_add_text -> proto_tree_add_subtree[_format]
    3. Use proto_tree_add_bitmask when appropriate.
    
    Change-Id: Iddbd2aadf5fd27f2cf9ba63873eb59dbd93b6394
    Reviewed-on: https://code.wireshark.org/review/4039
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  80407a4   Eliminate proto_tree_add_text from some of the dissectors.
    adds  f91ef6d   General cleanup of RTP-MIDI dissector.


Summary of changes:
 epan/dissectors/packet-rtp-midi.c | 1948 +++++++++++--------------------------
 1 file changed, 549 insertions(+), 1399 deletions(-)