Wireshark-commits: [Wireshark-commits] master 80407a4: Eliminate proto_tree_add_text from some of t
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 9 Sep 2014 01:25:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=80407a46df538011c1dcea96714c401a4078a697
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

80407a4 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate proto_tree_add_text from some of the dissectors.
    
    Other minor cleanups while in the area.
    
    Change-Id: I99096ade9c69a4c148962d45bb6b0bd775040ba1
    Reviewed-on: https://code.wireshark.org/review/4020
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  124923b   proto_tree_add_text -> something filterable.
    adds  80407a4   Eliminate proto_tree_add_text from some of the dissectors.


Summary of changes:
 epan/dissectors/packet-raw.c        |   19 ++-
 epan/dissectors/packet-redback.c    |   39 +++---
 epan/dissectors/packet-redbackli.c  |   12 +-
 epan/dissectors/packet-rlc-lte.c    |    6 +-
 epan/dissectors/packet-rlogin.c     |    8 +-
 epan/dissectors/packet-rmcp.c       |   10 +-
 epan/dissectors/packet-rmp.c        |    9 +-
 epan/dissectors/packet-roofnet.c    |    4 +-
 epan/dissectors/packet-rpl.c        |   41 +++---
 epan/dissectors/packet-rsh.c        |   16 ++-
 epan/dissectors/packet-rsip.c       |    3 +-
 epan/dissectors/packet-s5066dts.c   |  236 ++++++++++++++++++-----------------
 epan/dissectors/packet-sccpmg.c     |   25 ++--
 epan/dissectors/packet-sgsap.c      |   17 ++-
 epan/dissectors/packet-simulcrypt.c |   17 ++-
 epan/dissectors/packet-sita.c       |   16 +--
 epan/dissectors/packet-smb-browse.c |   27 ++--
 epan/dissectors/packet-smb-logon.c  |   68 +++++-----
 epan/dissectors/packet-smtp.c       |    7 +-
 epan/dissectors/packet-snaeth.c     |    6 +-
 epan/dissectors/packet-sndcp.c      |   18 +--
 epan/dissectors/packet-socks.c      |   38 ++++--
 epan/dissectors/packet-sscop.c      |   11 +-
 epan/dissectors/packet-ssl-utils.c  |    8 +-
 epan/dissectors/packet-sync.c       |   23 +++-
 25 files changed, 397 insertions(+), 287 deletions(-)