Wireshark-commits: [Wireshark-commits] master c612029: Exclude MA USB TransferAck's from USB conver
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 26 Aug 2014 19:37:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c612029774b9d680378bbbbaba2f4b7426fc7161
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c612029 by Sean O. Stalley (sean.stalley@xxxxxxxxx):

    Exclude MA USB TransferAck's from USB conversation
    
    the usb_trans_info struct only understands Requests & Responses.
    TransferAcks are currently treated as responses, which throws off
    the Request/Response pairing & dissection.
    
    This patch fixes tracking in the case when a TransferAck & TransferReq
    are in the same TCP packet. It does not fix the case where there are
    multiple TransferReq's or TransferResp's in 1 TCP packet.
    
    Eventually I want to revamp usb_trans_info structure to support:
     -multiple requests/responses per transaction (IE: retries)
     -TransferAck tracking
     -handling of multiple requests/responses in 1 TCP packet
    
    Change-Id: I09be6fecf55a40b4ea2a4f27bd753f3991ccabbd
    Reviewed-on: https://code.wireshark.org/review/3866
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  d6aa77d   Skinny:
    adds  c612029   Exclude MA USB TransferAck's from USB conversation


Summary of changes:
 epan/dissectors/packet-mausb.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)