Wireshark-commits: [Wireshark-commits] master d6aa77d: Skinny:
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 26 Aug 2014 18:58:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d6aa77d83b0b5335754b40c0d84af08252626c95
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d6aa77d by Diederik de Groot (ddegroot@xxxxxxxx):

    Skinny:
    
    Do not try to create a wmem_strbuf whose size is bigger than the max size allowed -> using wmem_strbuf_new instead of wmem_strbuf_sized_new (Evan Huus)
    While we are at it, fix errors spotted by the pre-commit tools/SkinnyProtocolOptimized -> Did not get any, can you specify which errors ? (Pascal Quantin)
    FT_IPv6: 'ENC_BIG_ENDIAN | ENC_NA' -> 'ENC_NA' only (2) (Pascal Quantin)
    Revert back to wmem_strbuf_sized_new instead of wmem_strbuf_new (Pascal Quantin)
    Use wmem_strbuf_sized_new maxlength = 0  (Pascal Quantin)
    
    Bug: 10409
    Bug: 10410
    Change-Id: Iebfcb53bc0a6289e02d10c38ecb717aa5c89389e
    Reviewed-on: https://code.wireshark.org/review/3862
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  efd9534   Add custom_layer_chm.xsl to UNKNOWN (fix checklicence)
    adds  d6aa77d   Skinny:


Summary of changes:
 epan/dissectors/packet-skinny.c     |   21 +++++++++------------
 epan/dissectors/packet-skinny.c.in  |    7 ++-----
 tools/parse_xml2skinny_dissector.py |    6 +++---
 3 files changed, 14 insertions(+), 20 deletions(-)