Wireshark · Wireshark-commits: [Wireshark-commits] master 6f104a0: Clean up the CRC-10 code.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6f104a0ffbfe2f01bb2b002aea91ea336daf8bf6
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6f104a0 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up the CRC-10 code.
    
    Have the wsutil routine just accumulate the stuff from the buffer handed
    to us.  Have the IUUP dissector deal with the extra stuff.  Add a
    update_crc10_by_bytes_tvb() routine, which is passed a tvbuff, offset,
    and length, and use that rather than using tvb_get_ptr() in dissectors.
    
    Change-Id: Iadd0823c764080e60d1339abb94d2e19150eabfe
    Reviewed-on: https://code.wireshark.org/review/3509
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  9b9005e   The DRM DCP CRC-16 is the same as the X.25 CRC-16.
    adds  6f104a0   Clean up the CRC-10 code.


Summary of changes:
 epan/CMakeLists.txt                   |    1 +
 epan/Makefile.common                  |    2 +
 epan/{tvbuff_base64.c => crc10-tvb.c} |   25 ++++++-------
 wsutil/bitswap.h => epan/crc10-tvb.h  |   14 +++----
 epan/dissectors/packet-atm.c          |   66 ++-------------------------------
 epan/dissectors/packet-iuup.c         |   21 +++++++++--
 wsutil/crc10.c                        |   22 ++++-------
 wsutil/crc10.h                        |    2 +-
 8 files changed, 50 insertions(+), 103 deletions(-)
 copy epan/{tvbuff_base64.c => crc10-tvb.c} (67%)
 copy wsutil/bitswap.h => epan/crc10-tvb.h (80%)