Wireshark-commits: [Wireshark-commits] master 9b9005e: The DRM DCP CRC-16 is the same as the X.25 C
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 8 Aug 2014 17:11:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9b9005eb94d9c89a02d93e8dda0c19b8e2d1a6d7
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9b9005e by Guy Harris (guy@xxxxxxxxxxxx):

    The DRM DCP CRC-16 is the same as the X.25 CRC-16.
    
    So just use crc16_x25_ccitt_tvb(), which goes a byte at a time rather
    than a bit at a time, and which takes a tvbuff rather than requiring you
    to call tvb_get_ptr().
    
    It also doesn't 1's-complement the result, so we can compare it against the
    0x1D0F in ETSI TS 102 821 V1.4.1 (2012-10) rather than against a
    1's-complement version, 0xE2F0.
    
    Change-Id: Ia513f851f0a8ff1e7853278ddf3618c532fb2aba
    Reviewed-on: https://code.wireshark.org/review/3507
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  57927c8   Fix compiler warning.
    adds  9b9005e   The DRM DCP CRC-16 is the same as the X.25 CRC-16.


Summary of changes:
 epan/dissectors/packet-dcp-etsi.c |   16 ++++++------
 wsutil/CMakeLists.txt             |    1 -
 wsutil/Makefile.common            |    2 --
 wsutil/crcdrm.c                   |   49 -------------------------------------
 wsutil/crcdrm.h                   |   34 -------------------------
 5 files changed, 7 insertions(+), 95 deletions(-)
 delete mode 100644 wsutil/crcdrm.c
 delete mode 100644 wsutil/crcdrm.h