Wireshark-commits: [Wireshark-commits] master b8a6cfc: Make Python mandatory to build on Windows
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 8 Aug 2014 05:59:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b8a6cfcb2aeb5d4aafdd657bdcc329f7899d82d2
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b8a6cfc by Роман Донченко (dpb@xxxxxxxxxxxxxx):

    Make Python mandatory to build on Windows
    
    While nominally optional, building without it doesn't work, so just make it
    mandatory.
    
    The verify_tools target already passes $(PYTHON) to win-setup.sh --appverify;
    we just need to supply a default value for PYTHON, so that $(PYTHON) doesn't
    expand to an empty string. It's also convenient for the developer if Python
    can be automatically found on the PATH.
    
    Change-Id: I4f54695625b74c5b4c758ef1e3bc9ed4467db514
    Reviewed-on: https://code.wireshark.org/review/3391
    Petri-Dish: Jörg Mayer <jmayer@xxxxxxxxx>
    Reviewed-by: Jörg Mayer <jmayer@xxxxxxxxx>
    Tested-by: Jörg Mayer <jmayer@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  4da7570   Use a QTreeWidget instead of QTableWidget.
    adds  b8a6cfc   Make Python mandatory to build on Windows


Summary of changes:
 config.nmake |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)