Wireshark-commits: [Wireshark-commits] master 4da7570: Use a QTreeWidget instead of QTableWidget.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4da7570809f7ea303ca15368d2c818fafc1a70f5
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
4da7570 by Gerald Combs (gerald@xxxxxxxxxxxxx):
Use a QTreeWidget instead of QTableWidget.
Even though Qt's widget naming suggests otherwise, a QTreeWidget is
usually a better choice for tables than QTableWidget. The former gives
you a nice, clean Plain Old Table while the latter gives you something
that looks and acts like a spreadsheet.
In this particular instance using QTreeWidget also gives us the option
of adding sub-items with detailed information. Do so for attached
addresses.
Allow sorting by traffic while we're here. Simplify the column hiding
logic. Make sure the sparkline delegate isn't editable.
Change-Id: Ia36ba2e12c1c0cb86ae5b2154e6afcf6549ae049
Reviewed-on: https://code.wireshark.org/review/3466
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Tested-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 40d5c50 Logcat Text: drop use of GDateTime
adds 4da7570 Use a QTreeWidget instead of QTableWidget.
Summary of changes:
ui/qt/capture_interfaces_dialog.cpp | 475 ++++++++++++++++++++---------------
ui/qt/capture_interfaces_dialog.h | 36 +--
ui/qt/capture_interfaces_dialog.ui | 176 ++++++-------
ui/qt/compiled_filter_output.cpp | 4 +-
ui/qt/compiled_filter_output.h | 4 +-
ui/qt/main_window_slots.cpp | 2 +-
ui/qt/manage_interfaces_dialog.cpp | 8 +-
ui/qt/manage_interfaces_dialog.h | 2 +-
ui/qt/sparkline_delegate.cpp | 8 +
ui/qt/sparkline_delegate.h | 1 +
10 files changed, 380 insertions(+), 336 deletions(-)
