Wireshark · Wireshark-commits: [Wireshark-commits] master-1.12 5e3b7ec: Introduce 802.11 dissectors with wired-in "FCS present" ind

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5e3b7ece7aabe4ffb53a2a4fdf4ac9fb3d5dcbd6
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

5e3b7ec by Guy Harris (guy@xxxxxxxxxxxx):

    Introduce 802.11 dissectors with wired-in "FCS present" indications.
    
    For a number of protocols that encapsulate 802.11 frames inside packets,
    whether the frame includes an FCS or not is specified by the protocol,
    not by whether the link-layer frame carrying the packets *itself*
    includes an FCS.  As we've done with Ethernet, add "_withfcs" and
    "_withoutfcs" dissectors, which *don't* check the pseudo-header FCS
    length indication, and call those, rather than dissectors that check the
    pseudo-header length indication, from the dissectors for those protocols.
    
    Change-Id: Ib8c8ecdd872e1782fdfc66e7573415d91911a62e
    Reviewed-on: https://code.wireshark.org/review/1866
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 21a1208735315a3a67e8a66ae6b5cb2776be6d60)
    Reviewed-on: https://code.wireshark.org/review/1867
    

Actions performed:

    from  42e8515   Have the protocol item cover only the PEEKREMOTE header.
    adds  5e3b7ec   Introduce 802.11 dissectors with wired-in "FCS present" indications.


Summary of changes:
 epan/dissectors/packet-aruba-erm.c  |    2 +-
 epan/dissectors/packet-capwap.c     |    2 +-
 epan/dissectors/packet-cisco-wids.c |    2 +-
 epan/dissectors/packet-ieee80211.c  |   60 +++++++++++++++++++++++++++--------
 epan/dissectors/packet-lwapp.c      |    4 +--
 epan/dissectors/packet-peekremote.c |    4 +--
 epan/dissectors/packet-sflow.c      |    2 +-
 epan/dissectors/packet-wassp.c      |    4 +--
 8 files changed, 56 insertions(+), 24 deletions(-)