Wireshark-commits: [Wireshark-commits] master 21a1208: Introduce 802.11 dissectors with wired-in "F
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 29 May 2014 17:57:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=21a1208735315a3a67e8a66ae6b5cb2776be6d60
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

21a1208 by Guy Harris (guy@xxxxxxxxxxxx):

    Introduce 802.11 dissectors with wired-in "FCS present" indications.
    
    For a number of protocols that encapsulate 802.11 frames inside packets,
    whether the frame includes an FCS or not is specified by the protocol,
    not by whether the link-layer frame carrying the packets *itself*
    includes an FCS.  As we've done with Ethernet, add "_withfcs" and
    "_withoutfcs" dissectors, which *don't* check the pseudo-header FCS
    length indication, and call those, rather than dissectors that check the
    pseudo-header length indication, from the dissectors for those protocols.
    
    Change-Id: Ib8c8ecdd872e1782fdfc66e7573415d91911a62e
    Reviewed-on: https://code.wireshark.org/review/1866
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  8b6c4e7   add gdb to the list of new protocols
    adds  21a1208   Introduce 802.11 dissectors with wired-in "FCS present" indications.


Summary of changes:
 epan/dissectors/packet-aruba-erm.c  |    2 +-
 epan/dissectors/packet-capwap.c     |    2 +-
 epan/dissectors/packet-cisco-wids.c |    2 +-
 epan/dissectors/packet-ieee80211.c  |   60 +++++++++++++++++++++++++++--------
 epan/dissectors/packet-lwapp.c      |    4 +--
 epan/dissectors/packet-peekremote.c |    4 +--
 epan/dissectors/packet-sflow.c      |    2 +-
 epan/dissectors/packet-wassp.c      |    4 +--
 8 files changed, 56 insertions(+), 24 deletions(-)