Wireshark-commits: [Wireshark-commits] master-1.8 3c4bb07: Thou shalt not put newlines in the strin
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 12 Mar 2014 22:36:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3c4bb077c9285fa3cd7eb06a1ec2297a14aa3c36
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.8
Repository: wireshark

Commits:

3c4bb07 by Guy Harris (guy@xxxxxxxxxxxx):

    Thou shalt not put newlines in the strings in value_string tables.
    
    That just breaks too many things.
    
    This catches the examples of that found in bug 9878.  There might be
    others that my grepping didn't find.
    
    We should also have the checkAPIs.pl script check for this, so this
    isn't a full fix for bug 9878.
    
    Change-Id: I92011dc51463f4090dd62aaf9a0571fe08d8c83d
    Reviewed-on: https://code.wireshark.org/review/626
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  fd4a89b   MAC LTE: fix a typo in Buffer Size value_string
    adds  3c4bb07   Thou shalt not put newlines in the strings in value_string tables.


Summary of changes:
 plugins/gryphon/packet-gryphon.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)