Wireshark-commits: [Wireshark-commits] master-1.10 c8b2829: Thou shalt not put newlines in the stri
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 12 Mar 2014 22:25:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c8b282976655e079060beeb59511ad4fdc28ff6a
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

c8b2829 by Guy Harris (guy@xxxxxxxxxxxx):

    Thou shalt not put newlines in the strings in value_string tables.
    
    That just breaks too many things.
    
    This catches the examples of that found in bug 9878.  There might be
    others that my grepping didn't find.
    
    We should also have the checkAPIs.pl script check for this, so this
    isn't a full fix for bug 9878.
    
    Change-Id: I9a25d8895b5febd2be55fc84332329fdf5b01ca0
    Reviewed-on: https://code.wireshark.org/review/625
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  5fe4cff   MAC LTE: fix a typo in Buffer Size value_string
    adds  c8b2829   Thou shalt not put newlines in the strings in value_string tables.


Summary of changes:
 asn1/lcsap/packet-lcsap-template.c |    6 ++----
 epan/dissectors/packet-lcsap.c     |   14 ++++++--------
 plugins/gryphon/packet-gryphon.c   |    2 +-
 3 files changed, 9 insertions(+), 13 deletions(-)