Wireshark · Wireshark-commits: [Wireshark-commits] master 1f2f2ba: Create/use an extended value-string; Move value-string array fro

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1f2f2ba5fa54586cfaa858004bfe021394be9c19
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1f2f2ba by Bill Meier (wmeier@xxxxxxxxxxx):

    Create/use an extended value-string; Move value-string array from .h file; Do other misc.
    
    - Value string arrrays should never be defined in a .h file (especially one
       included in multiple .c files).
      So: a. The value_string array (and associated #defines) was moved from the .h file
             to packet-rtp_events.c
          b. A public extended value_string was created in packet-rtp_events.c
              and declared as external in packet-rtp_events.h
    
    - Other:
      Remove a few unneeded initializers;
      Add editor modelines.
    
    Change-Id: Ib580c3e50ab5ce79484c9c6af57f62ca604b57d1
    Reviewed-on: https://code.wireshark.org/review/468
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    Tested-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  69a8881   Create/use several extended value-strings; Do several other small changes.
    adds  1f2f2ba   Create/use an extended value-string; Move value-string array from .h file; Do other misc.


Summary of changes:
 epan/dissectors/packet-rtp-events.c |  305 ++++++++++++++++++++++++++++++++---
 epan/dissectors/packet-rtp-events.h |  246 +---------------------------
 ui/gtk/voip_calls.c                 |    4 +-
 3 files changed, 285 insertions(+), 270 deletions(-)