Wireshark-commits: [Wireshark-commits] master 69a8881: Create/use several extended value-strings; D
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 3 Mar 2014 16:31:43 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=69a888110640d4f665f7a9f2a0340ee1e19803ad
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

69a8881 by Bill Meier (wmeier@xxxxxxxxxxx):

    Create/use several extended value-strings; Do several other small changes.
    
    - Move setting COL_PROTO & clearing COL_INFO to before a tvb fetch which
       could cause an exception;
    - Remove some unneeded initializers;
    - Fix up some long-lines and whitespace;
    - Use a consistent indentation;
    - Add editor modelines.
    
    Change-Id: I8a8015a65d5dc581ed02cbd134231481b9f96263
    Reviewed-on: https://code.wireshark.org/review/467
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    Tested-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  40e9465   Create/use an extended value_string; Do other misc minor changes.
    adds  69a8881   Create/use several extended value-strings; Do several other small changes.


Summary of changes:
 epan/dissectors/packet-sbus.c |   66 +++++++++++++++++++++++++----------------
 1 file changed, 40 insertions(+), 26 deletions(-)