Wireshark-bugs: [Wireshark-bugs] [Bug 10329] Probably wrong length check in proto_item_set_end
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 12 Sep 2014 14:10:59 +0000

Comment # 9 on bug 10329 from 
> *not* short-circuit if they're different (which should be rare).

Does the capture you're profiling hit this case a lot then? I thought it should
almost never happen, so I'd be very surprised if you're seeing it so much to
cause this much slowdown.

> Probably because the OPCUA code has been changed not to use proto_tree_add text().

A simple change to _add_item() wouldn't make a difference, they both use the
same TRY_TO_FAKE_THIS_ITEM logic.

> Could this type of problem be fixed in proto_item_set_end() instead?

No, there are a number of functions that depend on this behaviour being
correct, it would be fragile to try and fix them all - I believe my original
analysis/solution is correct, though there may be a case (ds_tvb == NULL?) in
which we can safely short-circuit which I missed in my original analysis.

You are receiving this mail because:
  • You are watching all bug changes.