Wireshark-bugs: [Wireshark-bugs] [Bug 10329] Probably wrong length check in proto_item_set_end
Anders Broman
changed
bug 10329
| What |
Removed |
Added |
| Status |
RESOLVED
|
CONFIRMED
|
| Resolution |
FIXED
|
---
|
Comment # 8
on bug 10329
from Anders Broman
Hi,
This change adversly effects performance acordibg to 2 valgrind runs I have
made.
Old result:
tools/valgrind-wireshark.sh -p -Y -b /home/ericsson/wireshark/
/home/ericsson/etxrab/TCT_SIP_traffic.pcapng
==13803== Callgrind, a call-graph generating cache profiler
==13803== Copyright (C) 2002-2013, and GNU GPL'd, by Josef Weidendorfer et al.
==13803== Using Valgrind-3.10.0.SVN and LibVEX; rerun with -h for copyright
info
==13803== Command: /home/ericsson/wireshark/.libs/lt-tshark -Y frame -nr
/home/ericsson/etxrab/TCT_SIP_traffic.pcapng
==13803==
==13803== For interactive control, run 'callgrind_control -h'.
==13803==
==13803== Events : Ir
==13803== Collected : 18090231417
==13803==
==13803== I refs: 18,090,231,417
New result.
2014-09-11 Wireshark 1.99.0 (v1.99.0-rc1-1731-g29993d5 from master
tools/valgrind-wireshark.sh -p -Y -b /home/ericsson/wireshark/
/home/ericsson/etxrab/TCT_SIP_traffic.pcapng
==27929== Callgrind, a call-graph generating cache profiler
==27929== Copyright (C) 2002-2013, and GNU GPL'd, by Josef Weidendorfer et al.
==27929== Using Valgrind-3.10.0.SVN and LibVEX; rerun with -h for copyright
info
==27929== Command: /home/ericsson/wireshark/.libs/lt-tshark -Y frame -nr
/home/ericsson/etxrab/TCT_SIP_traffic.pcapng
==27929==
==27929== For interactive control, run 'callgrind_control -h'.
==27929==
==27929== Events : Ir
==27929== Collected : 28056629440
==27929==
==27929== I refs: 28,056,629,440
Reverting the change and re running the included cature does NOT reveal the
original problem. Probably because the OPCUA code has been changed not to use
proto_tree_add text(). Could this type of problem be fixed in
proto_item_set_end() instead?
You are receiving this mail because:
- You are watching all bug changes.
